Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional 'include_email' query param for Twitter backend. #829

Merged
merged 1 commit into from
Aug 6, 2016

Conversation

halfstrik
Copy link

Added support for optional include_email parameter for Twitter backend.
Added test for checking email address receiving.
Updated docs.

Corresponding issue: #825

@omab omab merged commit a21f054 into omab:master Aug 6, 2016
@omab
Copy link
Owner

omab commented Aug 6, 2016

An earlier change included the include_email flag in the request, I've manually merged this PR to resolve the conflicts, but did mostly to preserve part of the docs and the new test case.

Thanks!

@berdon
Copy link

berdon commented Sep 22, 2016

I can't find any remnants of this merge / manual merge?

@dcmoore-gd
Copy link

@berdon Not sure about the actual merge, but here's where it appears:

params={'include_email': 'true'},

@berdon
Copy link

berdon commented Sep 23, 2016

@dcmoore-gd @omab Yeah, this eliminates the "optional" specificity and forces it. For those using twitter authentication that haven't been approved for email requesting, you get a 401 authorization required error.

@dcmoore-gd
Copy link

dcmoore-gd commented Sep 23, 2016

@berdon That's odd, we haven't experienced that 401 auth required error. We have apps with the email requesting both on and off with the latest version of PSA. Could there be some other factor causing it for you?

@berdon
Copy link

berdon commented Sep 23, 2016

Potentially - there's one other thing I need to check. But most of the posts around the VerifyCredentials and the change to the email requests (specifically the one that this CR was addressing) indicate the need for a specific Twitter authorization on an account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants